[dm-devel] dm cache: fix alloc_bitset check that always evaluates as false
Mike Snitzer
snitzer at redhat.com
Mon Jul 27 12:15:29 UTC 2015
On Thu, Jul 23 2015 at 11:47P -0400,
Colin King <colin.king at canonical.com> wrote:
> From: Colin Ian King <colin.king at canonical.com>
>
> static analysis by cppcheck has found a check on alloc_bitset that
> always evaluates as false and hence never finds an allocation failure:
>
> [drivers/md/dm-cache-policy-smq.c:1689]: (warning) Logical conjunction
> always evaluates to false: !EXPR && EXPR.
>
> Fix this by removing the incorrect mq->cache_hit_bits check
>
> Signed-off-by: Colin Ian King <colin.king at canonical.com>
Applied for 4.2-rc5 inclussion, thanks:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=134bf30c06f057d6b8d90132e8f8b3cd2be79572
More information about the dm-devel
mailing list