[dm-devel] [PATCH 10/15] multipath: blacklist virtio-blk devices

[Benjamin Marzinski]

On Sun, Mar 08, 2015 at 11:33:38AM +0100, Christophe Varoqui wrote:
>    Hi Xose,
>    it sure wouldn't hurt, be as there is no trailing "$" I guess the pattern
>    does its job as-is.
>    Please let me know if I'm reading this wrong.

You're reading it right. What's there will blacklist devices like "vdbx"
just fine. We could add a "$" and fully specify the pattern to make sure
we don't catch any devices by accident, but I don't really see that
happening with device names, and I've never seen any complaints about
the existing devnode balcklists that don't have them.

-Ben

>    Best regards,
>    Christophe Varoqui
>    OpenSVC
>    On Sun, Mar 8, 2015 at 11:24 AM, Xose Vazquez Perez
>    <[1]xose.vazquez at gmail.com> wrote:
> 
>      Benjamin Marzinski wrote:
> 
>      > virtio-blk devices don't report anything to use as a WWID, so
>      > multipath shouldn't waste it's time checking them.
>      >
>      > Signed-off-by: Benjamin Marzinski <[2]bmarzins at redhat.com>
>      > ---
>      >  libmultipath/blacklist.c | 2 +-
>      >  multipath.conf.defaults  | 2 +-
>      >  2 files changed, 2 insertions(+), 2 deletions(-)
>      >
>      > diff --git a/libmultipath/blacklist.c b/libmultipath/blacklist.c
>      > index 05f1697..cea128c 100644
>      > --- a/libmultipath/blacklist.c
>      > +++ b/libmultipath/blacklist.c
>      > @@ -178,7 +178,7 @@ setup_default_blist (struct config * conf)
>      >       if (store_ble(conf->blist_devnode, str, ORIGIN_DEFAULT))
>      >               return 1;
>      >
>      > -     str = STRDUP("^(td|hd)[a-z]");
>      > +     str = STRDUP("^(td|hd|vd)[a-z]");
>                                            ^
>                                            Missing "*" ?
> 
> References
> 
>    Visible links
>    1. mailto:xose.vazquez at gmail.com
>    2. mailto:bmarzins at redhat.com