[dm-devel] dm log userspace: use mempool_create_kmalloc_pool()
Mike Snitzer
snitzer at redhat.com
Wed Mar 18 22:30:46 UTC 2015
On Wed, Mar 11 2015 at 8:58am -0400,
Mike Snitzer <snitzer at redhat.com> wrote:
> On Sat, Mar 07 2015 at 7:43pm -0500,
> David Rientjes <rientjes at google.com> wrote:
>
> > Mempools created for kmalloc caches should use
> > mempool_create_kmalloc_pool().
> >
> > Cc: Alasdair Kergon <agk at redhat.com>
> > Cc: Mike Snitzer <snitzer at redhat.com>
> > Cc: Neil Brown <neilb at suse.de>
> > Signed-off-by: David Rientjes <rientjes at google.com>
>
> Thanks David, I'll get this queued up.
Turns out I already fixed this a different way about a month ago and
staged it for 4.1, see:
https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=db57216e710ea5c517f1030fafe7eb21ac938dc5
You'll be interested to note this portion of that commit's header:
"This _should_ eliminate DM's need for io_schedule_timeout() in
mempool_alloc(); so io_schedule() should be sufficient now."
I'll defer to you on whether you'd like to pursue switching to
io_schedule() in mempool_alloc().
More information about the dm-devel
mailing list