[dm-devel] [PATCH] dm-multipath: fix get_word return value when the last word is found

Vaughan Cao vaughan.cao at oracle.com
Fri Mar 20 09:01:54 UTC 2015


get_word() returns how many bytes it has parsed when it gets a new word.
But the deleted code will cause 0 returned for the last word, which
breaks this semantic. It hasn't cause any trouble yet because we have
been calling it as we are certain there is an word left.

Signed-off-by: Vaughan Cao <vaughan.cao at oracle.com>
---
 libmultipath/util.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libmultipath/util.c b/libmultipath/util.c
index ac0d1b2..0bb9c15 100644
--- a/libmultipath/util.c
+++ b/libmultipath/util.c
@@ -93,9 +93,6 @@ get_word (char * sentence, char ** word)
 	strchop(*word);
 	condlog(4, "*word = %s, len = %i", *word, len);
 
-	if (*p == '\0')
-		return 0;
-
 	return skip + len;
 }
 
-- 
1.9.0




More information about the dm-devel mailing list