[dm-devel] dm-snap-persistent: chunk_io doesn't call destroy_work_on_stack in 3.10.76

Akira Hayakawa ruby.wktk at gmail.com
Fri May 8 07:38:24 UTC 2015


Hi,

I am looking at 3.10.76 kernel and found that
chunk_io function of dm-snap-persistent doesn't call
destroy_work_on_stack to pair with INIT_WORK_ON_STACK.

        INIT_WORK_ONSTACK(&req.work, do_metadata);
        queue_work(ps->metadata_wq, &req.work);
        flush_workqueue(ps->metadata_wq);
        // I think you need it here
 
        return req.result;

Is it not buggy?

- Akira




More information about the dm-devel mailing list