[dm-devel] [PATCH] libmultipath: don't lock block device but use lock files

[Hannes Reinecke]

On 05/23/2015 11:00 PM, Christian Seiler wrote:
> In recent versions udev uses flock() on the device node itself,
> breaking libmultipath's current locking logic. Since libmultipath
> doesn't actually modify anything on the device itself (and hence does
> not actually need an exclusive lock on the device node, unlike e.g.
> tools that create partitions etc.), and the reason for the lock is to
> guard against multipath interfering with multipathd, use lock files
> (named after the devices) in /run/lock/multipath instead.
> 
> See the discussion under:
> https://www.redhat.com/archives/dm-devel/2014-December/msg00083.html
> Especially:
> https://www.redhat.com/archives/dm-devel/2014-December/msg00117.html
> 
> Signed-off-by: Christian Seiler <christian at iwakd.de>
> 
> ---
Well ... couldn't you just use a shared lock here?

I thought to have send this patch already; hmm.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare at suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multipath-shared-lock.patch
Type: text/x-patch
Size: 1539 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20150524/3745ea48/attachment.bin>