[dm-devel] dm: fix false alarm in free_rq_clone() for non blk-mq target

Junichi Nomura j-nomura at ce.jp.nec.com
Fri May 29 04:17:49 UTC 2015


On 05/29/15 12:18, Mike Snitzer wrote:
>> So I don't think it's necessary to extend dm_end_request() with 'mapped'
>> parameter.
> 
> I'm starting to question the need for 'must_be_mapped' param to
> free_rq_clone().  It was motivated by strange reports from Bart's
> testing but in reality I don't think it ever actually helped.
> 
> It was to act as a canary in the coal mine for the future but I'm now
> more inclined to just remove the parameter entirely.  Or do you think
> 'must_be_mapped' is still useful?

No. I think removing the parameter is good.

-- 
Jun'ichi Nomura, NEC Corporation




More information about the dm-devel mailing list