[dm-devel] [PATCH] dm snapshot: fix memory leak in error path
Michael Opdenacker
michael.opdenacker at free-electrons.com
Tue Oct 13 12:36:38 UTC 2015
Fix a memory leak in an error path (reported by Coverity CID 1326059)
Also add a missing workqueue deallocation in the same error path.
Signed-off-by: Michael Opdenacker <michael.opdenacker at free-electrons.com>
---
drivers/md/dm-snap-persistent.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/md/dm-snap-persistent.c b/drivers/md/dm-snap-persistent.c
index aeacad9be51d..1e980fa8bb8b 100644
--- a/drivers/md/dm-snap-persistent.c
+++ b/drivers/md/dm-snap-persistent.c
@@ -879,6 +879,8 @@ static int persistent_ctr(struct dm_exception_store *store, char *options)
store->userspace_supports_overflow = true;
else {
DMERR("Unsupported persistent store option: %s", options);
+ destroy_workqueue(ps->metadata_wq);
+ kfree(ps);
return -EINVAL;
}
}
--
2.1.4
More information about the dm-devel
mailing list