[dm-devel] [PATCH v4 18/79] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h

[Mikko Rapeli]

Hi,

On Thu, Oct 15, 2015 at 04:09:50AM -0400, Mike Snitzer wrote:
> On Thu, Oct 15 2015 at  1:55am -0400,
> Mikko Rapeli <mikko.rapeli at iki.fi> wrote:
> 
> > Fixes userspace compilation errors like:
> > 
> > linux/dm-log-userspace.h:416:2: error: unknown type name ‘uint64_t’
> > 
> > Signed-off-by: Mikko Rapeli <mikko.rapeli at iki.fi>
> 
> As was already explained before, there is no need to compile this for
> userspace consumption.  Where is this requirement coming from?

Sorry, maybe I did not understand this comment. Currently
include/uapi/linux/dm-log-userspace.h is in uapi headers and thus exported
to userspace and has this bug/feature which breaks a build.

Are you saying that it should not be exported to userspace at all and it
should be moved back to include/linux/dm-log.h?

I can prepare such a change instead.

> If your 0th patch's header speaks to _why_ you keep requesting this
> change then please cc me on it.

Sorry, I'm touching too many uapi headers with similar changes
so I can't Cc that many mailing lists and individuals with the cover
letter, but it is available here:

https://lkml.org/lkml/2015/10/15/22

-Mikko