[dm-devel] [PATCH 6/6] dm-stripe: Fix error message

Mike Snitzer snitzer at redhat.com
Wed Oct 28 19:51:28 UTC 2015


On Tue, Oct 27 2015 at  3:39pm -0400,
Tomohiro Kusumi <kusumi.tomohiro at gmail.com> wrote:

> The meaning of "not divisible by chunk size" has changed after
> d793e684, so the error message here should probably be using
> "Stripe length" since tmp_len is result of width/stripes, but
> not the whole target device size.
> 
> Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro at gmail.com>
> ---
>  drivers/md/dm-stripe.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/md/dm-stripe.c b/drivers/md/dm-stripe.c
> index 797ddb9..85cb09f 100644
> --- a/drivers/md/dm-stripe.c
> +++ b/drivers/md/dm-stripe.c
> @@ -127,7 +127,7 @@ static int stripe_ctr(struct dm_target *ti, unsigned int argc, char **argv)
>  
>  	tmp_len = width;
>  	if (sector_div(tmp_len, chunk_size)) {
> -		ti->error = "Target length not divisible by "
> +		ti->error = "Stripe length not divisible by "
>  		    "chunk size";
>  		return -EINVAL;
>  	}

There is no need for this change.  The user-facing error is more
meaningful.  The only input that is being checked here is the specified
target length.

Dropping this patch.




More information about the dm-devel mailing list