[dm-devel] [PATCH 2/2] multipath-tools: change default path_grouping_policy from failover to group_by_prio

[Xose Vazquez Perez]

On 07/28/2016 04:06 PM, Hannes Reinecke wrote:

> On 07/11/2016 11:12 PM, Xose Vazquez Perez wrote:
>> Default value is: failover
>>       5                 .pgpolicy      = GROUP_BY_SERIAL,
>>      23                 .pgpolicy      = MULTIBUS,
>>      48                 .pgpolicy      = GROUP_BY_PRIO,
>>
>> failover is only used by 1 device:
>> IBM/3303 NVDISK
>>
>> Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
>> Cc: device-mapper development <dm-devel at redhat.com>
>> Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>
>> ---
>>  libmultipath/defaults.h    |  2 +-
>>  libmultipath/hwtable.c     | 49 +---------------------------------------------
>>  multipath/multipath.conf.5 |  2 +-
>>  3 files changed, 3 insertions(+), 50 deletions(-)
>>

> Please reconsider.

It was done to minimize the number of options in hwtable.c
Also the output of the multipathd configuration is clearer, and it makes
easier to find misconfigured devices and attributes with weird values.

> 'group_by_prio' requires a working prioritizer, which we cannot assume
> for an unknown device.

I don't think that anyone can expect that a minimal config could work
automagically for the first time, with something like this:

devices {
	device {
		vendor  = "AUTOMATIC"
		product = "FORTHEPEOPLE"
	}
}


I do prefer a minimal set of options than a false automagical config.