[dm-devel] [PATCH 1/5] multipath-tools: add 'void' for no arguments functions

Xose Vazquez Perez xose.vazquez at gmail.com
Wed Aug 3 18:13:56 UTC 2016


Found by checkpatch - ERROR: Bad function definition

Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
Cc: device-mapper development <dm-devel at redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>
---
 libmpathpersist/mpath_pr_ioctl.c | 2 +-
 mpathpersist/main.c              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libmpathpersist/mpath_pr_ioctl.c b/libmpathpersist/mpath_pr_ioctl.c
index cf7141a..48d36e9 100644
--- a/libmpathpersist/mpath_pr_ioctl.c
+++ b/libmpathpersist/mpath_pr_ioctl.c
@@ -466,7 +466,7 @@ int mpath_translate_response (char * dev, struct sg_io_hdr io_hdr,
 	return MPATH_PR_SUCCESS;
 }
 
-int mpath_isLittleEndian()
+int mpath_isLittleEndian(void)
 {
 	int num = 1;
 	if(*(char *)&num == 1)
diff --git a/mpathpersist/main.c b/mpathpersist/main.c
index 6e922a2..5bf0740 100644
--- a/mpathpersist/main.c
+++ b/mpathpersist/main.c
@@ -675,7 +675,7 @@ void mpath_print_buf_readfullstat( struct prin_resp *pr_buff)
 	}
 }
 
-static void usage()
+static void usage(void)
 {
 	fprintf(stderr,
 			"Usage: mpathpersist [OPTIONS] [DEVICE]\n"
-- 
2.7.4




More information about the dm-devel mailing list