[dm-devel] [PATCH] dm raid: wrong status char during resynchronization

heinzm at redhat.com heinzm at redhat.com
Wed Aug 3 20:57:42 UTC 2016


From: Heinz Mauelshagen <heinzm at redhat.com>

During a resynchronization, device status char 'a' is
put on the raid status line for every device of a RAID set
changing to 'A' (unless device failure) when completed.

Interrupting and restarting an resynchronization by
reloading the table erroneously lead to status char 'A'.

Solve by avoiding superfluous MD_RECOVERY_REQUESTED flag
in raid_preresume().

Signed-off-by: Heinz Mauelshagen <heinzm at redhat.com>
---
 drivers/md/dm-raid.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
index 5ef6b5a..d20050c 100644
--- a/drivers/md/dm-raid.c
+++ b/drivers/md/dm-raid.c
@@ -3577,7 +3577,6 @@ static int raid_preresume(struct dm_target *ti)
 	/* Be prepared for mddev_resume() in raid_resume() */
 	set_bit(MD_RECOVERY_FROZEN, &mddev->recovery);
 	if (mddev->recovery_cp && mddev->recovery_cp < MaxSector) {
-		set_bit(MD_RECOVERY_REQUESTED, &mddev->recovery);
 		set_bit(MD_RECOVERY_SYNC, &mddev->recovery);
 		mddev->resync_min = mddev->recovery_cp;
 	}
-- 
2.5.5




More information about the dm-devel mailing list