[dm-devel] dm-mq and end_clone_request()
Mike Snitzer
snitzer at redhat.com
Thu Aug 4 16:10:47 UTC 2016
On Wed, Aug 03 2016 at 12:55pm -0400,
Bart Van Assche <bart.vanassche at sandisk.com> wrote:
> On 08/02/2016 05:40 PM, Mike Snitzer wrote:
> >But I asked you to run the v4.7 kernel patches I
> >pointed to _without_ any of your debug patches.
>
> I need several patches to fix bugs that are not related to the
> device mapper, e.g. "sched: Avoid that __wait_on_bit_lock() hangs"
> (https://lkml.org/lkml/2016/8/3/289).
OK, but you have way more changes than seem needed. In particular the
blk-mq error handling changes look suspect.
I'm also not sure what REQ_FAIL_IF_NO_PATH is all about (vaguely recall
seeing it before; and suggesting you use SCSI's more traditional
differentiated IO errors).
Anyway, at this point you're having us test too many changes that aren't
yet upstream:
$ git diff bart/srp-initiator-for-next dm/dm-4.7-mpath-fixes -- drivers block include kernel | diffstat
block/bio-integrity.c | 1
block/blk-cgroup.c | 4
block/blk-core.c | 16 ---
block/blk-mq.c | 16 ---
block/partition-generic.c | 3
drivers/acpi/acpica/nswalk.c | 1
drivers/infiniband/core/rw.c | 24 +++--
drivers/infiniband/core/verbs.c | 9 --
drivers/infiniband/hw/hfi1/Kconfig | 1
drivers/infiniband/hw/mlx4/qp.c | 6 -
drivers/infiniband/sw/rdmavt/Kconfig | 1
drivers/infiniband/ulp/isert/ib_isert.c | 2
drivers/infiniband/ulp/isert/ib_isert.h | 1
drivers/infiniband/ulp/srp/ib_srp.c | 131 --------------------------------
drivers/infiniband/ulp/srp/ib_srp.h | 5 -
drivers/infiniband/ulp/srpt/ib_srpt.c | 10 +-
drivers/infiniband/ulp/srpt/ib_srpt.h | 6 -
drivers/md/dm-crypt.c | 4
drivers/md/dm-ioctl.c | 77 +++++++++---------
drivers/md/dm-mpath.c | 32 -------
drivers/md/dm.c | 22 -----
drivers/scsi/scsi_lib.c | 36 +-------
drivers/scsi/scsi_priv.h | 2
drivers/scsi/scsi_scan.c | 2
drivers/scsi/scsi_sysfs.c | 48 -----------
drivers/scsi/sd.c | 6 -
drivers/scsi/sg.c | 3
include/linux/blk-mq.h | 3
include/linux/blk_types.h | 5 -
include/linux/blkdev.h | 1
include/linux/dmar.h | 2
include/rdma/ib_verbs.h | 6 -
include/scsi/scsi_device.h | 2
kernel/sched/wait.c | 2
34 files changed, 106 insertions(+), 384 deletions(-)
More information about the dm-devel
mailing list