[dm-devel] [PATCH V7 2/4] multipath-tools: New way to limit the IPC command length.

Bart Van Assche bart.vanassche at sandisk.com
Fri Aug 12 15:48:08 UTC 2016


On 08/12/2016 05:12 AM, Gris Ge wrote:
>     * Moved write_all() to file.h of libmultipath as all usage of
>       write_all() is against file rather than socket.

This sounds very wrong. As far as I can see write_all() is used to send 
data over a Unix socket. A Unix socket is not a file. Additionally, 
using write_all() to write to a file does not make sense. Please use 
write() to write to a file.

Bart.




More information about the dm-devel mailing list