[dm-devel] [PATCH] multipath-tools: replace LDFLAGS with LIBDEPS for groups of libraries in Makefiles

Xose Vazquez Perez xose.vazquez at gmail.com
Fri Aug 12 18:33:09 UTC 2016


On 08/12/2016 08:10 PM, Bart Van Assche wrote:

> It seems like a patch description that motivates why this change is considered useful is missing completely? Anyway, have you considered to use a name that is consistent by what is expected by
> automake, namely LDADD (see also https://www.gnu.org/software/automake/manual/html_node/Linking.html#Linking)?

I followed just same rule as in the rest of multipath-tools'
Makefiles. Where it's called "LIBDEPS":

libmpathpersist/Makefile:LIBDEPS +=  -lpthread -ldevmapper -ldl -L$(multipathdir) -lmultipath \
libmultipath/Makefile:          LIBDEPS += -lsystemd
libmultipath/Makefile:          LIBDEPS += -lsystemd-daemon




More information about the dm-devel mailing list