[dm-devel] [PATCH 6/6] multipathd: Remove a busy-waiting loop

Hannes Reinecke hare at suse.de
Wed Aug 17 14:44:17 UTC 2016


On 08/16/2016 10:11 PM, Bart Van Assche wrote:
> On 08/15/2016 11:31 PM, Hannes Reinecke wrote:
>> Makes one wonder: what happens to the waitevent threads?
>> We won't be waiting for them after applying this patch, right?
>> So why did we ever had this busy loop here?
>> Ben?
>>
>> (And while we're at the subject: can't we drop the waitevent threads
>> altogether? We're listening to uevents nowadays, so we should be
>> notified if something happened to the device-mapper tables. Which should
>> make the waitevent threads unnecessary, right?)
> 
> Hello Hannes,
> 
> Maybe this is not what you had in mind, but would you agree with the
> attached two patches?
> 
Well, yes, sort of.
However, it still would mean that the main multipath daemon thread might
terminate before the event threads have completed, though.

Not sure if it matters, just wanted to bring is up.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)




More information about the dm-devel mailing list