[dm-devel] [PATCH] multipath-tools: add CFLAGS to compilation options for prioritizers and checkers

[Xose Vazquez Perez]

On 11/27/2016 12:00 AM, Bart Van Assche wrote:

> On 11/26/16 14:26, Xose Vazquez Perez wrote:

>> Is there anything else missing or leftover?

>> $ git grep "(CC)"
>> Makefile.inc:   $(CC) $(CFLAGS) -c -o $@ $<
>> kpartx/Makefile:        $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) $(LIBDEPS)

->>> libmpathcmd/Makefile:   $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS)

>> libmpathpersist/Makefile:       $(CC) -c $(CFLAGS) *.c

->>> libmpathpersist/Makefile:       $(CC) $(LDFLAGS) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS)
->>> libmultipath/Makefile:  $(CC) $(LDFLAGS) $(SHARED_FLAGS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS) $(LIBDEPS)

>> libmultipath/checkers/Makefile: $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -lrados -ludev
>> libmultipath/checkers/Makefile: $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^ -laio
>> libmultipath/checkers/Makefile: $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^
>> libmultipath/prioritizers/Makefile:     $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^
>> libmultipath/prioritizers/Makefile:     $(CC) $(CFLAGS) $(LDFLAGS) $(SHARED_FLAGS) -o $@ $^
>> mpathpersist/Makefile:  $(CC) $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS) $(LIBDEPS)
>> multipath/Makefile:     $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS) $(LIBDEPS)
>> multipathd/Makefile:    $(CC) $(CFLAGS) $(OBJS) $(LDFLAGS) -o $(EXEC) $(LIBDEPS)
>> [...]

> What is the purpose of this patch and why do you think it is useful? It 
> is already possible to specify flags for linking shared libraries 
> through LDFLAGS. I don't see why CFLAGS should be added to the shared 
> library creation commands. Additionally, automake also ignores CFLAGS 
> when linking shared libraries. See also 
> https://www.gnu.org/software/automake/manual/html_node/Libtool-Flags.html#Libtool-Flags.

You are right.

I sent a patch to delete CFLAGS from the libmpathcmd, libmultipath and
libmpathpersist compilation flags.

Thanks for the review.