[dm-devel] [PATCH v2] crypto/mcryptd: Check mcryptd algorithm compatibility

[Herbert Xu]

On Tue, Dec 06, 2016 at 04:07:46PM -0500, Mikulas Patocka wrote:
> I think a proper fix would be to find the reason why mcryptd crashes and 
> fix that reason (i.e. make it fail in mcryptd_create_hash rather than 
> crash).
> 
> Testing flags could fix the bug for now but it could backfire later when 
> more algorithms are added.

I agree that a better solution is needed for the next merge window.
The problem here is that mcryptd is only meant to be used on specific
algorithms, so it shouldn't have been a template in the first place.

It should instead switch over to the simd model of creating new
algorithms.  So I'd like to see patch for the next merge window
that converted mcryptd and its users to something similar to what
we do in crypto/simd.c.

Thanks,
-- 
Email: Herbert Xu <herbert at gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt