[dm-devel] [PATCH v4 0/3] multipathd: skip spurious event message for blacklisted paths

Mauricio Faria de Oliveira mauricfo at linux.vnet.ibm.com
Wed Dec 14 13:05:28 UTC 2016


This patch-set prevents this error message on 'change'
uevents of paths that are blacklisted:

    sdb: spurious uevent, path not found

And in that case, replaces it with this _debug_ message
(so it's not logged by default; only when requested):

    sdb: spurious uevent, path is blacklisted

Patch 1/3 fixes a potential leak observed while doing that.
Patch 2/3 minor refactors two blacklist/filter checks into
          pathinfo() to clean-up a bit and fix a couple of
          bugs (reported by Ben and Hannes)
Patch 3/3 finally does what the patch-set is supposed to.

Changelog:
 - v2: switch approach from using path_discover() to using
       alloc_path_with_pathinfo() (Benjamin Marzinski).
 - v3: drop calls to udev_device_ref/unref() (Benjamin Marzinski)
       move filter_property() into pathinfo() (Benjamin Marzinski)
 - v4: move filter_devnode() into pathinfo() (Hannes Reinecke)
       ensure equivalency between path_discover() and pathinfo()
       for multipathd behavior.

Mauricio Faria de Oliveira (3):
  libmultipath: prevent memory leak in alloc_path_with_pathinfo() if
    pp_ptr is NULL
  libmultipath: move filter_property|devnode() from path_discover() into
    pathinfo()
  multipathd: skip spurious event message for blacklisted paths

 libmultipath/blacklist.c |  4 ++++
 libmultipath/discovery.c | 23 +++++++++++++++--------
 multipathd/main.c        | 17 ++++++++++++++++-
 3 files changed, 35 insertions(+), 9 deletions(-)

-- 
1.8.3.1




More information about the dm-devel mailing list