[dm-devel] [PATCH 1/2] multipath-tools: enable retain_hw_handler and detect_prio by default

Xose Vazquez Perez xose.vazquez at gmail.com
Sat Jul 9 00:48:46 UTC 2016


Based on previous Hannes's work.

He wrote:
"And for several versions (years, even) the linux kernel has the ability
to correctly detect the device handler, so we should be making
'retain_hw_handler' the default.
And if we do this we also want to enable 'detect_prio', to ensure
we pick the correct prioritizer."

Cc: Hannes Reinecke <hare at suse.de>
Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
Cc: device-mapper development <dm-devel at redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>
---
 libmultipath/defaults.h    | 4 ++--
 multipath/multipath.conf.5 | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/libmultipath/defaults.h b/libmultipath/defaults.h
index dc70a74..dd6a24b 100644
--- a/libmultipath/defaults.h
+++ b/libmultipath/defaults.h
@@ -16,8 +16,8 @@
 #define DEFAULT_FIND_MULTIPATHS	0
 #define DEFAULT_FAST_IO_FAIL	5
 #define DEFAULT_DEV_LOSS_TMO	600
-#define DEFAULT_RETAIN_HWHANDLER RETAIN_HWHANDLER_OFF
-#define DEFAULT_DETECT_PRIO	DETECT_PRIO_OFF
+#define DEFAULT_RETAIN_HWHANDLER RETAIN_HWHANDLER_ON
+#define DEFAULT_DETECT_PRIO	DETECT_PRIO_ON
 #define DEFAULT_DEFERRED_REMOVE	DEFERRED_REMOVE_OFF
 #define DEFAULT_DELAY_CHECKS	DELAY_CHECKS_OFF
 #define DEFAULT_UEVENT_STACKSIZE 256
diff --git a/multipath/multipath.conf.5 b/multipath/multipath.conf.5
index 709ab3c..1da2de1 100644
--- a/multipath/multipath.conf.5
+++ b/multipath/multipath.conf.5
@@ -561,7 +561,7 @@ mutipath.conf. If the SCSI layer has not attached a hardware handler,
 multipath will continue to use its configured hardware handler.
 .RS
 .TP
-Default value is: \fBno\fR
+Default value is: \fByes\fR
 .RE
 .TP
 .B detect_prio
@@ -573,7 +573,7 @@ device will automatically use the
 prioritizer. If not, the prioritizer will be selected as usual.
 .RS
 .TP
-Default value is: \fBno\fR
+Default value is: \fByes\fR
 .RE
 .TP
 .B force_sync
-- 
2.7.4




More information about the dm-devel mailing list