[dm-devel] [PATCH 2/3] multipath-tools: merge OPTFLAGS into CFLAGS

[Christophe Varoqui]

Reverted.

On Fri, Jul 15, 2016 at 12:19 PM, Hannes Reinecke <hare at suse.de> wrote:

> On 07/08/2016 06:28 PM, Xose Vazquez Perez wrote:
> > OPTFLAGS is not used anywhere, but maybe it's intrusive for
> distributions.
> >
> > Cc: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre at canonical.com>
> > Cc: Dragan Stancevic <dragan.stancevic at canonical.com>
> > Cc: Louis Bouchard <louis.bouchard at canonical.com>
> > Cc: Ritesh Raj Sarraf <rrs at debian.org>
> > Cc: Benjamin Marzinski <bmarzins at redhat.com>
> > Cc: Hannes Reinecke <hare at suse.de>
> > Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
> > Cc: device-mapper development <dm-devel at redhat.com>
> > Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>
> > ---
> >  Makefile.inc | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/Makefile.inc b/Makefile.inc
> > index 01d743c..b7077fc 100644
> > --- a/Makefile.inc
> > +++ b/Makefile.inc
> > @@ -60,10 +60,9 @@ RM          = rm -f
> >  LN          = ln -sf
> >  INSTALL_PROGRAM = install
> >
> > -OPTFLAGS     = -Wunused -Wstrict-prototypes -O2 -g -pipe
> -Wformat-security -Wall \
> > -             -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
> --param=ssp-buffer-size=4
> > -
> > -CFLAGS            = $(OPTFLAGS) -fPIC -DLIB_STRING=\"${LIB}\"
> -DRUN_DIR=\"${RUN}\"
> > +CFLAGS      = -Wunused -Wstrict-prototypes -O2 -g -pipe
> -Wformat-security -Wall \
> > +             -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
> --param=ssp-buffer-size=4 \
> > +             -fPIC -DLIB_STRING=\"${LIB}\" -DRUN_DIR=\"${RUN}\"
> >  SHARED_FLAGS = -shared
> >
> >  %.o: %.c
> >
> Nope, doesn't work for us.
> Our buildsystem is using a distinct set of flags, which we need to use
> for the build process.
> At the same time we have no idea if there are other flags (like includes
> etc) which are required by the build itself.
>
> Please revert, this breaks our build.
>
> Cheers,
>
> Hannes
> --
> Dr. Hannes Reinecke                Teamlead Storage & Networking
> hare at suse.de                                   +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
> HRB 21284 (AG Nürnberg)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20160722/9a24cda4/attachment.htm>