[dm-devel] [PATCH 7/7] multipathd: Fix a use-after-free

Bart Van Assche bart.vanassche at sandisk.com
Thu Jul 28 13:57:20 UTC 2016


On 07/28/16 06:45, Hannes Reinecke wrote:
> On 07/27/2016 11:14 PM, Bart Van Assche wrote:
>> diff --git a/multipathd/main.c b/multipathd/main.c
>> index f4c8245..6a4135c 100644
>> --- a/multipathd/main.c
>> +++ b/multipathd/main.c
>> @@ -2376,9 +2376,11 @@ child (void * param)
>>  	}
>>
>>  	lock(vecs->lock);
>> +	conf = get_multipath_config();
>>  	if (conf->queue_without_daemon == QUE_NO_DAEMON_OFF)
>>  		vector_foreach_slot(vecs->mpvec, mpp, i)
>>  			dm_queue_if_no_path(mpp->alias, 0);
>> +	put_multipath_config(conf);
>>  	remove_maps_and_stop_waiters(vecs);
>>  	unlock(vecs->lock);
>>
>>
> This one is already included in my patch 'multipathd: Correctly
> invalidate configuration during shutdown', which also contains some
> additional fixes for RCU config access.
>
> I would prefer taking that instead of this patch.

Hello Hannes,

You are right. I had not yet noticed that your patch includes the above 
change. Christophe, please drop this patch.

Bart.




More information about the dm-devel mailing list