[dm-devel] [PATCH 2/2] multipath-tools: change default path_grouping_policy from failover to group_by_prio

[Hannes Reinecke]

On 07/11/2016 11:12 PM, Xose Vazquez Perez wrote:
> Default value is: failover
>       5                 .pgpolicy      = GROUP_BY_SERIAL,
>      23                 .pgpolicy      = MULTIBUS,
>      48                 .pgpolicy      = GROUP_BY_PRIO,
> 
> failover is only used by 1 device:
> IBM/3303 NVDISK
> 
> Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
> Cc: device-mapper development <dm-devel at redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>
> ---
>  libmultipath/defaults.h    |  2 +-
>  libmultipath/hwtable.c     | 49 +---------------------------------------------
>  multipath/multipath.conf.5 |  2 +-
>  3 files changed, 3 insertions(+), 50 deletions(-)
> 
Please reconsider.

'group_by_prio' requires a working prioritizer, which we cannot assume
for an unknown device.

To handle this situation properly we should be using 'group_by_prio' as
the default is a prioritizer is found and switch to 'failover' for all
other cases.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		   Teamlead Storage & Networking
hare at suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)