[dm-devel] [PATCH 05/57] Add HP MSA 2040 to the hardware table

[Xose Vazquez Perez]

On 06/10/2016 08:17 AM, Hannes Reinecke wrote:

> On 06/09/2016 04:20 PM, Xose Vazquez Perez wrote:

>> In VxVM(libvxmsa2kfc_sa) they are grouped that way:
>> https://web.archive.org/web/20160608233140/https://sort.veritas.com/asl/details/756
>>
>> Otherwise if hwtable.c is filled with a lot of duplicate entries,
>> it could be unmanageable.

> Well.
> MSA2000 is already out of support, and P2000 is heading there.
> So it's _extremely_ unlikely that we get additional hardware entries for
> those.
> At the same time, re-grouping hardware entries by combining regular
> expressions always has the real risk of messing up the regular
> expressions, and requires a test on the actual hardware to check if we
> didn't mess up. Seeing the both are basically unsupported it'll get hard
> to validate this.
> For this reasons I prefer to leave them alone.

BTW, a "Unit serial number" attribute could be added to provide more flexibility.