[dm-devel] [PATCH] multipath-tools: add VIOLIN/CONCERTO ARRAY to hardware table

[Xose Vazquez Perez]

On 06/10/2016 03:56 PM, Xose Vazquez Perez wrote:

> based on documentation provided by manufacturer:
> https://drive.google.com/open?id=0B_B6YmEmO7cDQlMzc1BsaUxZRVU

Please, DROP this patch. It's buggy.

>  libmultipath/hwtable.c | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 66b5123..a9cd080 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -1176,6 +1176,25 @@ static struct hwentry default_hw[] = {
>  		.checker_name  = TUR,
>  	},
>  	/*
> +	 * Violin Memory, Inc.
> +	 *
> +	 * Maintainer : Christophe Varoqui
> +	 * Mail : christophe.varoqui at opensvc.com
> +	 */
> +	{
> +		.vendor        = "VIOLIN",
> +		.product       = "CONCERTO ARRAY",
> +		.selector      = "round-robin 0",
> +		.pgpolicy      = MULTIBUS,
> +		.prio_name     = PRIO_ALUA,
> +		.checker_name  = TUR,
> +		.minio         = 100,
> +		.rr_weight     = priorities,
                                 ^^^^^^^^^^^
It should be  RR_WEIGHT_PRIO

> +		.pgfailback    = -FAILBACK_IMMEDIATE,
> +		.features      = "1 queue_if_no_path",
> +		.no_path_retry = 300,
> +	},
> +	/*
>  	 * EOL
>  	 */
>  	{
>