[dm-devel] [PATCH 05/39] libmultipath: memory leak in remove_feature()
Hannes Reinecke
hare at suse.de
Thu Jun 16 09:47:11 UTC 2016
Upon error the 'n' string was never freed.
Found by coverity.
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
libmultipath/structs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libmultipath/structs.c b/libmultipath/structs.c
index 502d98e..ed62b07 100644
--- a/libmultipath/structs.c
+++ b/libmultipath/structs.c
@@ -653,9 +653,11 @@ remove_feature(char **f, char *o)
* about to be removed
*/
p = strchr(*f, ' ');
- if (!p)
+ if (!p) {
/* Internal error, feature string inconsistent */
+ FREE(n);
return 1;
+ }
while (*p == ' ')
p++;
p--;
--
2.6.6
More information about the dm-devel
mailing list