[dm-devel] [PATCH 07/39] libmultipath: missing NULL check in set_pgfailback()

Hannes Reinecke hare at suse.de
Thu Jun 16 09:47:13 UTC 2016


Found by coverity.

Signed-off-by: Hannes Reinecke <hare at suse.com>
---
 libmultipath/dict.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libmultipath/dict.c b/libmultipath/dict.c
index 7f912ec..9920a9b 100644
--- a/libmultipath/dict.c
+++ b/libmultipath/dict.c
@@ -805,6 +805,8 @@ set_pgfailback(vector strvec, void *ptr)
 	char * buff;
 
 	buff = set_value(strvec);
+	if (!buff)
+		return 1;
 
 	if (strlen(buff) == 6 && !strcmp(buff, "manual"))
 		*int_ptr = -FAILBACK_MANUAL;
-- 
2.6.6




More information about the dm-devel mailing list