[dm-devel] [PATCH 11/39] libmultipath/devmapper.c: check for errors from sscanf()
Hannes Reinecke
hare at suse.de
Thu Jun 16 09:47:17 UTC 2016
Found by coverity.
Signed-off-by: Hannes Reinecke <hare at suse.com>
---
libmultipath/devmapper.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
index f395481..0223e18 100644
--- a/libmultipath/devmapper.c
+++ b/libmultipath/devmapper.c
@@ -116,7 +116,10 @@ dm_lib_prereq (void)
dm_get_library_version(version, sizeof(version));
condlog(3, "libdevmapper version %s", version);
- sscanf(version, "%d.%d.%d ", &v[0], &v[1], &v[2]);
+ if (sscanf(version, "%d.%d.%d ", &v[0], &v[1], &v[2]) != 3) {
+ condlog(0, "invalid libdevmapper version %s", version);
+ return 1;
+ }
if VERSION_GE(v, minv)
return 0;
--
2.6.6
More information about the dm-devel
mailing list