[dm-devel] [PATCH 08/10] multipath-tools: remove USER_FRIENDLY_NAMES_OFF

Christophe Varoqui christophe.varoqui at opensvc.com
Mon Jun 20 06:58:07 UTC 2016


I tend to agree with Xose this is unfair to set user_friendly_name in the
hwtable entries.
Does anybody have a vote against my merging this patch ?

On Fri, Jun 17, 2016 at 4:52 PM, Xose Vazquez Perez <xose.vazquez at gmail.com>
wrote:

> This is up to sysadmins, and it is already off by default.
>
> Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
> Cc: device-mapper development <dm-devel at redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>
> ---
>  libmultipath/hwtable.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 598b9b8..bef8d31 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -794,7 +794,6 @@ static struct hwentry default_hw[] = {
>                 .prio_name     = PRIO_ONTAP,
>                 .prio_args     = NULL,
>                 .retain_hwhandler = RETAIN_HWHANDLER_ON,
> -               .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
>                 .detect_prio   = DETECT_PRIO_ON,
>         },
>         /*
> @@ -1133,7 +1132,6 @@ static struct hwentry default_hw[] = {
>                 .pgfailback    = -FAILBACK_IMMEDIATE,
>                 .checker_name  = TUR,
>                 .fast_io_fail  = 10,
> -               .user_friendly_names = USER_FRIENDLY_NAMES_OFF,
>                 .prio_name     = DEFAULT_PRIO,
>                 .no_path_retry = 0,
>                 .dev_loss      = 60,
> --
> 2.5.5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20160620/8ad95253/attachment.htm>


More information about the dm-devel mailing list