[dm-devel] [PATCH] dmsetup: improve message command

[Zdenek Kabelac]

Dne 18.3.2016 v 12:06 Werner Koch napsal(a):
> On Fri, 26 Feb 2016 12:42, wk at gnupg.org said:
>
>> I am playing with a new crypto container format and propose to enhance
>> "dmsetup message" to accept the actual message from stdin instead of
>> taking it only from the command line.  This is useful to set a key and
>
> Is there anything I can do to help you evaluate the patch?
>


Hi

It looked usable - thought could you trim down the zeroing of
dm-malloced area (wipememory)  macro.

It's useless for heap allocation.

Unless you show example and compiler which would optimize 'library' call away.
a) such compiler would be horrible broken (since I could always LD_PRELOAD
my free() implementation),
b) we would need to do same for dm_task_struct - since your 'dmsetup mem
is duplicated for dm_task.

Regards

Zdenek