[dm-devel] [PATCH 17/20] dm: get rid of superfluous gfp flags

Michal Hocko mhocko at kernel.org
Mon May 2 07:31:11 UTC 2016


On Fri 29-04-16 14:54:52, Mike Snitzer wrote:
> On Thu, Apr 28 2016 at  9:24am -0400,
> Michal Hocko <mhocko at kernel.org> wrote:
> 
> > From: Michal Hocko <mhocko at suse.com>
> > 
> > copy_params seems to be little bit confused about which allocation flags
> > to use. It enforces GFP_NOIO even though it uses
> > memalloc_noio_{save,restore} which enforces GFP_NOIO at the page
> > allocator level automatically (via memalloc_noio_flags). It also
> > uses __GFP_REPEAT for the __vmalloc request which doesn't make much
> > sense either because vmalloc doesn't rely on costly high order
> > allocations. Let's just drop the __GFP_REPEAT and leave the further
> > cleanup to later changes.
> > 
> > Cc: Shaohua Li <shli at kernel.org>
> > Cc: Mikulas Patocka <mpatocka at redhat.com>
> > Cc: dm-devel at redhat.com
> > Signed-off-by: Michal Hocko <mhocko at suse.com>
> 
> I've taken this patch for 4.7 but editted the header, see:
> https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.7&id=0222c76e96163355620224625c1cd80991086dc7

Thanks!

-- 
Michal Hocko
SUSE Labs




More information about the dm-devel mailing list