[dm-devel] [PATCH 3/7] dm-mpath: Document a locking assumption
Mike Snitzer
snitzer at redhat.com
Fri Nov 18 00:07:17 UTC 2016
On Tue, Nov 15 2016 at 6:33pm -0500,
Bart Van Assche <bart.vanassche at sandisk.com> wrote:
> Document that __pg_init_all_paths() must be called with
> multipath.lock held.
>
> Signed-off-by: Bart Van Assche <bart.vanassche at sandisk.com>
> ---
> drivers/md/dm-mpath.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index e477af8..f1e226d 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -348,6 +348,8 @@ static int __pg_init_all_paths(struct multipath *m)
> struct pgpath *pgpath;
> unsigned long pg_init_delay = 0;
>
> + lockdep_assert_held(&m->lock);
> +
> if (atomic_read(&m->pg_init_in_progress) || test_bit(MPATHF_PG_INIT_DISABLED, &m->flags))
> return 0;
>
> --
> 2.10.1
>
The leading underscores document the need for locking
(__pg_init_all_paths vs pg_init_all_paths).
More information about the dm-devel
mailing list