[dm-devel] [PATCH] Add blkzonecmd and blkreport ZAC/ZBC drives
Shaun Tancheff
shaun at tancheff.com
Mon Nov 21 21:37:01 UTC 2016
On Mon, Nov 21, 2016 at 1:51 PM, Bart Van Assche
<bart.vanassche at sandisk.com> wrote:
> On 11/21/2016 11:29 AM, Shaun Tancheff wrote:
>>
>> This patch adds:
>> - blkreset to issue Reset (Write Pointer) zone commands
>> - blkreport to retrieve drive zone information
>>
>> Signed-off-by: Shaun Tancheff <shaun.tancheff at seagate.com>
>> Signed-off-by: Shaun Tancheff <shaun at tancheff.com>
>
>
> Is this patch perhaps intended for the util-linux project? According to the
> README file of that project util-linux patches should be sent to
> util-linux at vger.kernel.org.
>
> Additionally, shouldn't Damien Le Moal have been CC'ed for this patch?
Yes this was supposed to go to util-linux.
Will Cc Damien as well.
>> diff --git a/configure.ac b/configure.ac
>> index 1bd7d2e..b8df1d4 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -275,6 +275,12 @@ AC_CHECK_HEADERS([security/pam_misc.h],
>> #endif
>> ])
>>
>> +AC_CHECK_HEADERS([linux/blkzoned.h], [], [], [
>> +#ifdef HAVE_BLKZONED_H
>> +#include <linux/blkzoned.h>
>> +#endif
>> +])
>
>
> What code in configure.ac defines HAVE_BLKZONED_H? Would the following code
> have been sufficient: AC_CHECK_HEADER([linux/blkzoned.h]) ? See also
> https://www.gnu.org/software/autoconf/manual/autoconf-2.68/html_node/Generic-Headers.html.
Thanks for the heads up, my use of check headers here wasn't doing
what I thought.
I've fixed it and will post to util-linux.
Thanks!
--Shaun
More information about the dm-devel
mailing list