[dm-devel] [PATCH 3/4] multipath-tools: change default failback from manual to undefined

[Hannes Reinecke]

On 10/03/2016 01:29 PM, Christophe Varoqui wrote:
> Wouldn't it be nicer to keep manual as the default and remove all
> FAILBACK_UNDEF from the hwtable ?
> 
> In the current code base, FAILBACK_UNDEF causes need_switch_pathgroup()
> to refresh each path prio and mpp->bestpg, and return to the caller it
> should switch pathgroup. But the caller (check_path()) won't switch anyway.
> 
> As I read it FAILBACK_UNDEF never fails back automatically, like
> FAILBACK_MANUAL, but causes unecessary work.
> 
> Hannes, Ben, do you confirm I read correctly ? Would you ack to removal
> of FAILBACK_UNDEF from the hwtable ?
> 
Yes, please.
FAILBACK_UNDEF always was kinda pointless, as and we're now using
defaults more aggressively I'm all for dropping FAILBACK_UNDEF and use
FAILBACK_MANUAL as the default.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare at suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)