[dm-devel] [PATCH] multipath-tools: remove hwhandler when it's alua

[Christophe Varoqui]

I'm not comfortable with this patch that induces a less predictable
behaviour.
We have that retain hardware handler switch that users can activate to
achieve the purpose.

Hannes, Ben, would you support that patch ?

Best Regards,
Christophe

On Thu, Oct 6, 2016 at 8:50 PM, Xose Vazquez Perez <xose.vazquez at gmail.com>
wrote:

> Autodetected.
>
> Cc: Hannes Reinecke <hare at suse.de>
> Cc: Christophe Varoqui <christophe.varoqui at opensvc.com>
> Cc: device-mapper development <dm-devel at redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez at gmail.com>
> ---
>  libmultipath/hwtable.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c
> index 367aa0a..1fc2f24 100644
> --- a/libmultipath/hwtable.c
> +++ b/libmultipath/hwtable.c
> @@ -46,7 +46,6 @@ static struct hwentry default_hw[] = {
>                 .product       = "VV",
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = -FAILBACK_IMMEDIATE,
> -               .hwhandler     = "1 alua",
>                 .prio_name     = PRIO_ALUA,
>                 .no_path_retry = 18,
>         },
> @@ -124,7 +123,6 @@ static struct hwentry default_hw[] = {
>                 /* SAN Virtualization Services Platform */
>                 .vendor        = "HP",
>                 .product       = "HSVX700",
> -               .hwhandler     = "1 alua",
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = -FAILBACK_IMMEDIATE,
>                 .no_path_retry = 12,
> @@ -504,7 +502,6 @@ static struct hwentry default_hw[] = {
>                 .vendor        = "IBM",
>                 .product       = "^IPR",
>                 .no_path_retry = NO_PATH_RETRY_QUEUE,
> -               .hwhandler     = "1 alua",
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = -FAILBACK_IMMEDIATE,
>                 .prio_name     = PRIO_ALUA,
> @@ -546,7 +543,6 @@ static struct hwentry default_hw[] = {
>         {
>                 .vendor        = "AIX",
>                 .product       = "NVDISK",
> -               .hwhandler     = "1 alua",
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = -FAILBACK_IMMEDIATE,
>                 .no_path_retry = (300 / DEFAULT_CHECKINT),
> @@ -654,7 +650,6 @@ static struct hwentry default_hw[] = {
>                 /* M-Series */
>                 .vendor        = "NEC",
>                 .product       = "DISK ARRAY",
> -               .hwhandler     = "1 alua",
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = -FAILBACK_IMMEDIATE,
>                 .prio_name     = PRIO_ALUA,
> @@ -780,7 +775,6 @@ static struct hwentry default_hw[] = {
>         {
>                 .vendor        = "(Intel|INTEL)",
>                 .product       = "Multi-Flex",
> -               .hwhandler     = "1 alua",
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = -FAILBACK_IMMEDIATE,
>                 .no_path_retry = NO_PATH_RETRY_QUEUE,
> @@ -792,7 +786,6 @@ static struct hwentry default_hw[] = {
>         {
>                 .vendor        = "(LIO-ORG|SUSE)",
>                 .product       = "RBD",
> -               .hwhandler     = "1 alua",
>                 .pgpolicy      = GROUP_BY_PRIO,
>                 .pgfailback    = -FAILBACK_IMMEDIATE,
>                 .no_path_retry = 12,
> --
> 2.10.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20161011/cddd382e/attachment.htm>