[dm-devel] [PATCH 00/15] Fifteen multipath-tools patches

[tang.junhui at zte.com.cn]

Hello Bart,
I also think that we do not need init_path_check_interval()，
since pp->checkint is initialized in configure() too.

Cheers,
Tang




发件人:         Bart Van Assche <bart.vanassche at sandisk.com>
收件人:         <tang.junhui at zte.com.cn>, 
<christophe.varoqui at opensvc.com>, 
抄送:   bart.vanassche at sandisk.com, dm-devel at redhat.com
日期:   2016/10/11 04:41
主题:   Re: [dm-devel] [PATCH 00/15] Fifteen multipath-tools patches
发件人: dm-devel-bounces at redhat.com



On 10/07/2016 07:05 PM, tang.junhui at zte.com.cn wrote:
> "0007-multipathd-Fix-a-data-race.patch"
>
> This patch solved the data race problem,
>
> but the assignment for paths check interval has no effect,
>
> since there is no path in vecs when calling
> init_path_check_interval(vecs) in child(),
>
> I think it is better to call
>  init_path_check_interval(vecs) at reconfigure() or configure()
>
> after the paths has created in vecs .

Hello Tang,

If init_path_check_interval() doesn't have any effect then I propose to 
remove that function. pp->checkint is namely already initialized in 
cli_add_path().

Bart.

--
dm-devel mailing list
dm-devel at redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20161012/7639e85c/attachment.htm>