[dm-devel] [PATCH 03/15] libmultipath: Remove an incorrect comment

Bart Van Assche bart.vanassche at sandisk.com
Fri Oct 21 18:42:19 UTC 2016


It is easy to see that uevq_lockp is not held while service_uevq()
is called. Since no other code accesses the list that is processed
by this function calling service_uevq() without holding uevq_lockp
is safe. Hence remove the comment about locking above service_uevq().

Signed-off-by: Bart Van Assche <bart.vanassche at sandisk.com>
---
 libmultipath/uevent.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libmultipath/uevent.c b/libmultipath/uevent.c
index 0f32dbc..f844294 100644
--- a/libmultipath/uevent.c
+++ b/libmultipath/uevent.c
@@ -104,9 +104,6 @@ setup_thread_attr(pthread_attr_t *attr, size_t stacksize, int detached)
 	}
 }
 
-/*
- * Called with uevq_lockp held
- */
 void
 service_uevq(struct list_head *tmpq)
 {
-- 
2.10.1




More information about the dm-devel mailing list