[dm-devel] [PATCH 01/10] libmultipath: add skip_kpartx option

[Hannes Reinecke]

On 10/29/2016 04:55 AM, Benjamin Marzinski wrote:
> This option gives multipath the ability to stop kpartx from running. The
> previous idea, the "no_partitions" feature, was not accepted in the
> upstream kernel. This method uses one of the dm cookie subsystem flags
> DM_SUBSYSTEM_UDEV_FLAG1, which can be checked by udev to skip running
> kpartx when processing the event. This patch does most of the work
> necessary to make this work.  It doesn't change kpartx.rules, however.
>
> Also, if dm_suspend_and_flush_map fails, multipath doesn't know how the
> device is configured. so, it simply checks if the device has any
> partitions before attempting the remove, and if not, sets the
> DM_SUBSYSTEM_UDEV_FLAG1 on the resume after failure, so that no
> partitions will be generated.
>
> Signed-off-by: Benjamin Marzinski <bmarzins at redhat.com>
> ---
>  libmultipath/config.c      |  2 ++
>  libmultipath/config.h      |  3 +++
>  libmultipath/configure.c   |  5 +++--
>  libmultipath/defaults.h    |  1 +
>  libmultipath/devmapper.c   | 45 +++++++++++++++++++++++++++++++--------------
>  libmultipath/devmapper.h   |  8 +++++++-
>  libmultipath/dict.c        | 13 +++++++++++++
>  libmultipath/propsel.c     | 18 ++++++++++++++++++
>  libmultipath/propsel.h     |  1 +
>  libmultipath/structs.h     |  7 +++++++
>  multipath/multipath.conf.5 | 17 +++++++++++++++++
>  multipathd/cli_handlers.c  |  4 +++-
>  12 files changed, 106 insertions(+), 18 deletions(-)
>
Thank you for this.

Reviewed-by: Hannes Reinecke <hare at suse.com>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare at suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)