[dm-devel] [PATCH 2/9] dm: Rename a function argument

Bart Van Assche Bart.VanAssche at sandisk.com
Thu Sep 1 14:17:11 UTC 2016


On 08/31/16 20:29, Mike Snitzer wrote:
> On Wed, Aug 31 2016 at  6:16pm -0400,
> Bart Van Assche <bart.vanassche at sandisk.com> wrote:
>
>> Rename 'interruptible' into 'sleep_state' to make it clear that this
>> argument is a task state instead of a boolean.
>
> Shouldn't the type also be changed from int to long (to match 'state'
> member from 'struct task_struct')?

Hello Mike,

Today TASK_STATE_MAX equals 2048. So I think an int is big enough even 
on 32-bit platforms. Please let me know if you really want me to change 
the type from int to long.

Bart.




More information about the dm-devel mailing list