[dm-devel] [PATCH 8/9] dm: Fix two race conditions related to stopping and starting queues

[Bart Van Assche]

On 09/01/2016 03:27 PM, Mike Snitzer wrote:
> On Thu, Sep 01 2016 at  6:22pm -0400,
> Bart Van Assche <bart.vanassche at sandisk.com> wrote:
>
>> On 09/01/2016 03:18 PM, Mike Snitzer wrote:
>>> FYI I get the same 'dmsetup suspend --nolockfs --noflush mp' hang,
>>> running mptest's test_02_sdev_delete, when I try your unmodified
>>> patchset, see:
>>>
>>> http://git.kernel.org/cgit/linux/kernel/git/snitzer/linux.git/log/?h=devel.bart
>>
>> Hello Mike,
>>
>> Are you aware that the code on that branch is a *modified* version
>> of my patch series? The following patch is not present on that
>> branch: "dm path selector: Avoid that device removal triggers an
>> infinite loop". There are also other (smaller) differences.
>
> No, you're obviously talking about the 'devel' branch and not the
> 'devel.bart' branch I pointed to.  The 'devel.bart' branch is the
> _exact_ patchset you sent.  It has the same problem as the 'devel'
> branch.

Hello Mike,

Sorry that I misread your previous e-mail. After I received your latest 
e-mail I rebased my tree on top of the devel.bart branch mentioned 
above. My tests still pass. The only two patches in my tree that are 
relevant and that are not in the devel.bart branch have been attached to 
this e-mail. Did your test involve the sd driver? If so, do the attached 
two patches help? If the sd driver was not involved, can you provide 
more information about the hang you ran into? The output and log 
messages generated by the following commands after the hang has been 
reproduced would be very welcome:
* echo w > /proc/sysrq-trigger
* (cd /sys/block && grep -a '' dm*/mq/*/{pending,cpu*/rq_list})

Thanks,

Bart.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-block-dm-mpath-Introduce-request-flag-REQ_FAIL_IF_NO.patch
Type: text/x-patch
Size: 2858 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20160901/53a6c82c/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-sd-Fix-a-deadlock.patch
Type: text/x-patch
Size: 8344 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/dm-devel/attachments/20160901/53a6c82c/attachment-0001.bin>