[dm-devel] [PATCH 17/33] multipathd: imply -n if find_multipaths is set

[Benjamin Marzinski]

On Tue, Feb 28, 2017 at 05:23:13PM +0100, Martin Wilck wrote:
> Automatic detection of new devices with find_multipaths
> doesn't work correctly currently. Therefore, for now,
> imply ignore_new_devs if find_multipaths is seen.

I would rather not do this (at least outside of the initramfs), since it
keeps multipathd from automatically creating multipath devices as
expected when you enable find_multipaths. I admit that these path
devices won't be correctly claimed in udev when they appear for the
first time, but it's hard to believe that they are critical the very
first time they appear on the system. I have a patch that I can send
upstream that triggers a change uevent on path devices when they are
added to the wwids file.  This means that these devices will be
correctly claimed by multipath as soon as it gets set up on top of them.

Martin, what do you thing about reverting this change and triggering a
uevent instead?

-Ben
 
> Signed-off-by: Martin Wilck <mwilck at suse.com>
> ---
>  multipathd/main.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/multipathd/main.c b/multipathd/main.c
> index cf44778b..8f464bfb 100644
> --- a/multipathd/main.c
> +++ b/multipathd/main.c
> @@ -2183,6 +2183,10 @@ reconfigure (struct vectors * vecs)
>  		conf->verbosity = verbosity;
>  	if (bindings_read_only)
>  		conf->bindings_read_only = bindings_read_only;
> +	if (conf->find_multipaths) {
> +		condlog(2, "find_multipaths is set: -n is implied");
> +		ignore_new_devs = 1;
> +	}
>  	if (ignore_new_devs)
>  		conf->ignore_new_devs = ignore_new_devs;
>  	uxsock_timeout = conf->uxsock_timeout;
> -- 
> 2.11.0
> 
> --
> dm-devel mailing list
> dm-devel at redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel