[dm-devel] [PATCH] multipathd daemon: Fix incorrect use of CLOCK_MONOTONIC in pthread
Gris Ge
fge at redhat.com
Wed Aug 9 13:22:14 UTC 2017
Issue:
When multipathd is starting up, it will reply "timeout\n" immediatly
when got any IPC command from socket. The expected way is to wait
uxsock_timeout/1000 seconds.
Root cause:
pthread_mutex_timedlock() are expecting a CLOCK_REALTIME time.
Fix:
Use CLOCK_REALTIME for pthread_mutex_timedlock() and
pthread_cond_timedwait().
Signed-off-by: Gris Ge <fge at redhat.com>
---
multipathd/cli.c | 2 +-
multipathd/main.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/multipathd/cli.c b/multipathd/cli.c
index 32d49766..002abe61 100644
--- a/multipathd/cli.c
+++ b/multipathd/cli.c
@@ -475,7 +475,7 @@ parse_cmd (char * cmd, char ** reply, int * len, void * data, int timeout )
/*
* execute handler
*/
- if (clock_gettime(CLOCK_MONOTONIC, &tmo) == 0) {
+ if (clock_gettime(CLOCK_REALTIME, &tmo) == 0) {
tmo.tv_sec += timeout;
} else {
tmo.tv_sec = 0;
diff --git a/multipathd/main.c b/multipathd/main.c
index 4be2c579..67997d08 100644
--- a/multipathd/main.c
+++ b/multipathd/main.c
@@ -198,7 +198,7 @@ int set_config_state(enum daemon_status state)
if (running_state != DAEMON_IDLE) {
struct timespec ts;
- clock_gettime(CLOCK_MONOTONIC, &ts);
+ clock_gettime(CLOCK_REALTIME, &ts);
ts.tv_sec += 1;
rc = pthread_cond_timedwait(&config_cond,
&config_lock, &ts);
--
2.14.0
More information about the dm-devel
mailing list