[dm-devel] [PATCH 3/7] dm-mpath: Do not lock up a CPU with requeuing activity

Bart Van Assche bart.vanassche at wdc.com
Wed Aug 9 18:32:12 UTC 2017


When using the block layer in single queue mode, get_request()
returns ERR_PTR(-EAGAIN) if the queue is dying and the REQ_NOWAIT
flag has been passed to get_request(). Avoid that the kernel
reports soft lockup complaints in this case due to continuous
requeuing activity.

Signed-off-by: Bart Van Assche <bart.vanassche at wdc.com>
Cc: Laurence Oberman <loberman at redhat.com>
Cc: <stable at vger.kernel.org>
---
 drivers/md/dm-mpath.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
index 0e8ab5bb3575..0baa461eccaa 100644
--- a/drivers/md/dm-mpath.c
+++ b/drivers/md/dm-mpath.c
@@ -504,7 +504,6 @@ static int multipath_clone_and_map(struct dm_target *ti, struct request *rq,
 		if (queue_dying) {
 			atomic_inc(&m->pg_init_in_progress);
 			activate_or_offline_path(pgpath);
-			return DM_MAPIO_REQUEUE;
 		}
 		return DM_MAPIO_DELAY_REQUEUE;
 	}
-- 
2.13.3




More information about the dm-devel mailing list