[dm-devel] [PATCH 4/7] dm-mpath: Avoid that building with W=1 causes gcc 7 to complain about fall-through
Christoph Hellwig
hch at lst.de
Thu Aug 10 09:29:43 UTC 2017
On Wed, Aug 09, 2017 at 11:32:13AM -0700, Bart Van Assche wrote:
> Signed-off-by: Bart Van Assche <bart.vanassche at wdc.com>
> Cc: Laurence Oberman <loberman at redhat.com>
> ---
> drivers/md/dm-mpath.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
> index 0baa461eccaa..6e20deac4add 100644
> --- a/drivers/md/dm-mpath.c
> +++ b/drivers/md/dm-mpath.c
> @@ -1379,6 +1379,7 @@ static void pg_init_done(void *data, int errors)
> case SCSI_DH_RETRY:
> /* Wait before retrying. */
> delay_retry = 1;
> + /* fall through */
> case SCSI_DH_IMM_RETRY:
> case SCSI_DH_RES_TEMP_UNAVAIL:
> if (pg_init_limit_reached(m, pgpath))
I prefer /*FALLTHRU*/ over the less shouty lower case version, but either
way this looks okay:
Reviewed-by: Christoph Hellwig <hch at lst.de>
More information about the dm-devel
mailing list