[dm-devel] [PATCH 2/3] multipath-tools: libdmmp: Improve timeout mechanism

[Martin Wilck]

On Wed, 2017-08-16 at 20:34 +0800, Gris Ge wrote:
> Issue:
>     libdmmp return error of timeout before user requested timeout was
>     met.
>     This happens when multipathd daemon is starting with a lot(1k+)
> mpaths.
> 
> Root cause:
>     The multipath has two timeout settings:
>         1. 'uxsock_timeout' in multipath.conf
>         2. libmpathcmd timeout argument.
>     And the first is not controllable in current libdmmp code.
> 
> Fix:
>     * Only keep 1 timeout setting in libdmmp:
>         dmmp_context_timeout_set()/dmmp_context_timeout_get().
>     * libdmmp will keep reply until meet user requested timeout.

Maybe I'm missing something here, but if you just retry the timed-out
command, isn't it likely that you'll hit the uxsock_timeout again and
again?

Best,
Martin

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)