[dm-devel] [PATCH] multipath-tools: support for coalescing heterogenous paths

[Guan Junxiong]

Hi, guys,

Any comments about this patch?

IMO, this feature of coalescing heterogenous paths without interrupting
uplayer transaction is worthy to integrate into multipath-tools. Please
consider about it.

I am glad to see if there is anything which can be improve for this patch.

Thanks
Guan Junxiong


On 2017/8/17 16:15, Guan Junxiong wrote:
> This patch supports coalescing heterogenous paths by using
> udev rules files. This is useful in the scenario of migrating
> data for heterogenous arrays without interrupting uplayer
> transaction. The udev rules file, which is located in the
> /etc/udev/rules.d/ directory, is automatically generated by
> multipath with new options -m and -n.
> 
> For example:
> multipath -m dm-0 -n  1000036006016028
> 
> The geneated udev rules is as follows:
> KERNEL=="sd*[!0-9]|nvme*[0-9]n*[0-9]", ENV{DEVTYPE}=="disk",
> ENV{ID_SERIAL}=="1000036006016028", ENV{ID_SERIAL}="36006016-
> 028f03600588db521dc7ce71"
> 
> KERNEL=="sd*[!0-9]|nvme*[0-9]n*[0-9]", ENV{DEVTYPE}=="disk",
> ENV{ID_WWN}=="1000036006016028", ENV{ID_WWN}="36006016028f036-
> 00588db521dc7ce71"
> 
> KERNEL=="sd*[!0-9]|nvme*[0-9]n*[0-9]", ENV{DEVTYPE}=="disk",
> ENV{ID_UUID}=="1000036006016028", ENV{ID_UUID}="36006016028f03-
> 600588db521dc7ce71"
> 
> Signed-off-by: Junxiong Guan <guanjunxiong at huawei.com>
> ---
>  libmultipath/Makefile   |   3 +-
>  libmultipath/config.h   |   1 +
>  libmultipath/udevrule.c | 191 ++++++++++++++++++++++++++++++++++++++++++++++++
>  libmultipath/udevrule.h |  13 ++++
>  multipath/main.c        |  29 +++++++-
>  multipath/multipath.8   |  12 +++
>  6 files changed, 247 insertions(+), 2 deletions(-)
>  create mode 100644 libmultipath/udevrule.c
>  create mode 100644 libmultipath/udevrule.h