[dm-devel] [PATCH 2/2] dm-io: remove BIOSET_NEED_RESCUER flag from bios bioset

NeilBrown neilb at suse.com
Tue Aug 29 22:10:18 UTC 2017


BIOSET_NEED_RESCUER is only need on a bioset is
allocations will be made inside a make_request_fn()
call.

dm_io() is called from make_request_fn() context.
The closest it comes is in chunk_io() in
dm-snap-persistent.  Here the code uses a separate
thread to avoid problems.

So BIOSET_NEED_RESCUER is not needed.

Signed-off-by: NeilBrown <neilb at suse.com>
---
 drivers/md/dm-io.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/md/dm-io.c b/drivers/md/dm-io.c
index 25039607f3cb..bafd9f79aa3b 100644
--- a/drivers/md/dm-io.c
+++ b/drivers/md/dm-io.c
@@ -58,8 +58,7 @@ struct dm_io_client *dm_io_client_create(void)
 	if (!client->pool)
 		goto bad;
 
-	client->bios = bioset_create(min_ios, 0, (BIOSET_NEED_BVECS |
-						  BIOSET_NEED_RESCUER));
+	client->bios = bioset_create(min_ios, 0, BIOSET_NEED_BVECS);
 	if (!client->bios)
 		goto bad;
 





More information about the dm-devel mailing list