[dm-devel] [PATCH] multipath-tools: Makefile: Respect standard toolchain related envvars

[Martin Wilck]

On Wed, 2017-12-13 at 14:28 +0100, Xose Vazquez Perez wrote:
> On 12/12/2017 04:28 PM, Bart Van Assche wrote:
> > On Thu, 2017-11-30 at 00:23 +0100, Thomas Deutschmann wrote:
> > > The Makefile overrides standard envvars that control the
> > > toolchain flags.
> > > This patch should set things right without reducing default
> > > behavior.
> > > 
> > > Signed-off-by: Thomas Deutschmann <whissi at gentoo.org>
> > > 
> >
> > Hello Thomas,
> > 
> > I agree that we need a way to specify additional compilation flags.
> > However, is
> > OPTFLAGS really a standard? Aren't most developers used to set
> > CFLAGS to specify
> > additional compilation flags?
> 
> OPTFLAGS is used by RPM distributions(Fedora, openSUSE and
> derivatives).

I'm not sure what you mean. At openSUSE, we simply set 
OPTFLAGS=%{optflags} in the spec file. RPM_OPT_FLAGS aka %{optflags} is
a standard for RPM-based distros, but "OPTFLAGS" is not.

Martin

-- 
Dr. Martin Wilck <mwilck at suse.com>, Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)