[dm-devel] [PATCH 1/2] dm bufio: add missed destroy of client's mutex

Aliaksei Karaliou akaraliou.dev at gmail.com
Sat Dec 23 10:27:03 UTC 2017


dm_bufio_client_destroy() does not destroy dm_bufio_client->lock.
dm_bufio_client_create() does not do that on fallback path too.

Signed-off-by: Aliaksei Karaliou <akaraliou.dev at gmail.com>
---
 drivers/md/dm-bufio.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/md/dm-bufio.c b/drivers/md/dm-bufio.c
index c546b567f3b5..1c661d4c211c 100644
--- a/drivers/md/dm-bufio.c
+++ b/drivers/md/dm-bufio.c
@@ -1767,6 +1767,7 @@ struct dm_bufio_client *dm_bufio_client_create(struct block_device *bdev, unsign
 	}
 	dm_io_client_destroy(c->dm_io);
 bad_dm_io:
+	mutex_destroy(&c->lock);
 	kfree(c);
 bad_client:
 	return ERR_PTR(r);
@@ -1811,6 +1812,7 @@ void dm_bufio_client_destroy(struct dm_bufio_client *c)
 		BUG_ON(c->n_buffers[i]);
 
 	dm_io_client_destroy(c->dm_io);
+	mutex_destroy(&c->lock);
 	kfree(c);
 }
 EXPORT_SYMBOL_GPL(dm_bufio_client_destroy);
-- 
2.11.0




More information about the dm-devel mailing list